Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bare metal OS requirements #7023

Merged
merged 5 commits into from
Jan 2, 2024
Merged

Add bare metal OS requirements #7023

merged 5 commits into from
Jan 2, 2024

Conversation

chrisdoherty4
Copy link
Contributor

@chrisdoherty4 chrisdoherty4 commented Nov 10, 2023

Also update the NPM arg so we can run make server.

@eks-distro-bot eks-distro-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 10, 2023
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4e9fecf) 71.76% compared to head (5bf04c6) 71.71%.
Report is 88 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7023      +/-   ##
==========================================
- Coverage   71.76%   71.71%   -0.05%     
==========================================
  Files         532      552      +20     
  Lines       41627    42895    +1268     
==========================================
+ Hits        29873    30762     +889     
- Misses      10078    10426     +348     
- Partials     1676     1707      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eks-distro-bot eks-distro-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 10, 2023
Copy link
Member

@chrisnegus chrisnegus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit.

@chrisdoherty4
Copy link
Contributor Author

/approve
/cherry-pick release-0.18

@eks-distro-pr-bot
Copy link
Contributor

@chrisdoherty4: once the present PR merges, I will cherry-pick it on top of release-0.18 in a new PR and assign it to you.

In response to this:

/approve
/cherry-pick release-0.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrisdoherty4

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@chrisnegus chrisnegus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of small suggestions.

@chrisnegus
Copy link
Member

/lgtm

@eks-distro-bot eks-distro-bot merged commit 48435f1 into aws:main Jan 2, 2024
13 checks passed
@eks-distro-pr-bot
Copy link
Contributor

@chrisdoherty4: new pull request created: #7246

In response to this:

/approve
/cherry-pick release-0.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/docs Documentation documentation lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants