Copy Rufio Machine v1alpha1 types from upstream: #6721
Conversation
eks-distro-bot
added
the
size/XL
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6721 +/- ##
=======================================
Coverage 75.66% 75.66%
=======================================
Files 475 475
Lines 38404 38404
=======================================
Hits 29059 29059
Misses 7733 7733
Partials 1612 1612
☔ View full report in Codecov by Sentry. |
This allows us to not have to import Rufio. Rufio uses controller-runtime v0.15.0 (and soon v0.16.2). EKS Anywhere use v0.14.2. Upgrading EKS Anywhere means all other dependent libraries will need upgraded too. This is not feasible at the moment from a time perspective, there are too many to update. For example: capv, capc, capd, abhay-krishna/cluster-api, aws/etcdadm-bootstrap-provider, etc. Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
jacobweinstock
force-pushed
the
rufio-apis
branch
from
e03b7fa to
01a8acf
Compare
This was missed from upstream. Also, it allows for not including these internal structs when they are nil. Helpful in yaml marshalling, etc. Signed-off-by: Jacob Weinstock <[email protected]>
There was a problem hiding this comment.
More of an organizational thing, but I don't think we'd want third party APIs under the api pkg because this seems like an internal concern and not something we're interested in advertising outwardly.
We do have /pkg/providers/tinkerbell/rufiounreleased. Perhaps we compartmentalize that to /pkg/providers/tinkerbell/rufio/api/{unreleased,v1alpha1}?
There was a problem hiding this comment.
Ignore this. I didn't realize the thirdparty already exists.
|
/approve |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrisdoherty4, jacobweinstock The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issue #, if available:
Description of changes:
This allows us to not have to import Rufio. Rufio uses controller-runtime v0.15.0 (and soon v0.16.2). EKS Anywhere use v0.14.2. Upgrading EKS Anywhere means all other dependent libraries will need upgraded too. This is not feasible at the moment from a time perspective, there are too many to update. For example: capv, capc, capd, abhay-krishna/cluster-api, aws/etcdadm-bootstrap-provider, etc.
Testing (if applicable):
Documentation added/planned (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.