Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminate ec2 instance runner after e2e tests #6713

Merged

Conversation

g-gaston
Copy link
Member

Description of changes

Instead of waiting for the job to clean the up, we now terminate the instance immediately. All logs and tests artifacts should already be uploaded by this time, that should be our tool to debug tests.

The main benefit here is we avoid lingering instances that might still be running something (like a kind cluster) that could keep hitting the infra APIs, which could overwhelm them if too many are doing that at the same time. This gets even worse when they overlap with the next test run.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@g-gaston
Copy link
Member Author

/cherry-pick release-0.17

@eks-distro-bot eks-distro-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 22, 2023
@eks-distro-pr-bot
Copy link
Contributor

@g-gaston: once the present PR merges, I will cherry-pick it on top of release-0.17 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.01% 🎉

Comparison is base (f76d5f3) 75.62% compared to head (3989056) 75.64%.
Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6713      +/-   ##
==========================================
+ Coverage   75.62%   75.64%   +0.01%     
==========================================
  Files         473      474       +1     
  Lines       38155    38303     +148     
==========================================
+ Hits        28854    28973     +119     
- Misses       7703     7723      +20     
- Partials     1598     1607       +9     

see 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@g-gaston
Copy link
Member Author

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: g-gaston

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit 49e0d2c into aws:main Sep 22, 2023
5 checks passed
@eks-distro-pr-bot
Copy link
Contributor

@g-gaston: new pull request created: #6714

In response to this:

/cherry-pick release-0.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants