-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend Etcd Encryption API and add more validations and defaults #6708
Extend Etcd Encryption API and add more validations and defaults #6708
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #6708 +/- ##
==========================================
+ Coverage 75.59% 75.64% +0.04%
==========================================
Files 474 474
Lines 38250 38303 +53
==========================================
+ Hits 28916 28973 +57
+ Misses 7726 7723 -3
+ Partials 1608 1607 -1
☔ View full report in Codecov by Sentry. |
9ac299e
to
1d29417
Compare
1d29417
to
46c4742
Compare
/test eks-anywhere-presubmit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/woof
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/approve |
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavmpandey08 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description of changes:
Extend Etcd Encryption API and add more validations and defaults with unit tests
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.