Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend Etcd Encryption API and add more validations and defaults #6708

Merged

Conversation

abhinavmpandey08
Copy link
Member

Description of changes:
Extend Etcd Encryption API and add more validations and defaults with unit tests

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 20, 2023
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.04% 🎉

Comparison is base (8382d1a) 75.59% compared to head (46c4742) 75.64%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6708      +/-   ##
==========================================
+ Coverage   75.59%   75.64%   +0.04%     
==========================================
  Files         474      474              
  Lines       38250    38303      +53     
==========================================
+ Hits        28916    28973      +57     
+ Misses       7726     7723       -3     
+ Partials     1608     1607       -1     
Files Changed Coverage Δ
pkg/api/v1alpha1/cluster_defaults.go 75.00% <ø> (ø)
pkg/api/v1alpha1/cluster_webhook.go 92.90% <100.00%> (ø)
pkg/api/v1alpha1/etcdencryption.go 100.00% <100.00%> (ø)
pkg/providers/vsphere/vsphere.go 68.82% <100.00%> (+0.39%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abhinavmpandey08 abhinavmpandey08 force-pushed the extend-etcd-encryption-api branch from 9ac299e to 1d29417 Compare September 21, 2023 00:26
@abhinavmpandey08 abhinavmpandey08 force-pushed the extend-etcd-encryption-api branch from 1d29417 to 46c4742 Compare September 21, 2023 00:33
@pokearu
Copy link
Member

pokearu commented Sep 21, 2023

/test eks-anywhere-presubmit

Copy link
Member

@pokearu pokearu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/woof

@eks-distro-bot
Copy link
Collaborator

@pokearu: dog image

In response to this:

/lgtm
/woof

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abhinavmpandey08
Copy link
Member Author

/approve
/woof

@eks-distro-bot
Copy link
Collaborator

@abhinavmpandey08: dog image

In response to this:

/approve
/woof

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavmpandey08

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit d7f7813 into aws:main Sep 21, 2023
5 checks passed
@abhinavmpandey08 abhinavmpandey08 deleted the extend-etcd-encryption-api branch September 21, 2023 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants