Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate release testdata files #6702

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

eks-distro-pr-bot
Copy link
Contributor

Generate release testdata files.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot
Copy link
Collaborator

Hi @eks-distro-pr-bot. Thanks for your PR.

I'm waiting for a aws member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eks-distro-bot eks-distro-bot added needs-ok-to-test size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 19, 2023
@eks-distro-pr-bot eks-distro-pr-bot force-pushed the update-release-test-file branch 3 times, most recently from 949bb12 to ed3e21a Compare September 19, 2023 20:13
Copy link
Contributor

@TerryHowe TerryHowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/unhold
/ok-to-test

@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (8382d1a) 75.59% compared to head (facdadf) 75.60%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6702   +/-   ##
=======================================
  Coverage   75.59%   75.60%           
=======================================
  Files         474      474           
  Lines       38250    38251    +1     
=======================================
+ Hits        28916    28920    +4     
+ Misses       7726     7724    -2     
+ Partials     1608     1607    -1     
Files Changed Coverage Δ
pkg/providers/vsphere/vsphere.go 68.82% <100.00%> (+0.39%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@TerryHowe TerryHowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@TerryHowe
Copy link
Contributor

/re-test

@abhay-krishna
Copy link
Member

/lgtm
/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhay-krishna, TerryHowe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [TerryHowe,abhay-krishna]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@abhay-krishna abhay-krishna merged commit 2e62e98 into aws:main Sep 26, 2023
mitalipaygude pushed a commit to mitalipaygude/eks-anywhere-1 that referenced this pull request Nov 28, 2023
eks-distro-bot pushed a commit that referenced this pull request Nov 28, 2023
* [PR BOT] Generate release testdata files (#6702)

* Add feature flag for unify controller CLI workflow

---------

Co-authored-by: EKS Distro PR Bot <[email protected]>
mitalipaygude pushed a commit to mitalipaygude/eks-anywhere-1 that referenced this pull request Nov 29, 2023
mitalipaygude pushed a commit to mitalipaygude/eks-anywhere-1 that referenced this pull request Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants