-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore node taints when scheduling Cilium preflight daemonset #6697
Conversation
2b1f049
to
55f435a
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #6697 +/- ##
==========================================
- Coverage 75.61% 75.60% -0.02%
==========================================
Files 474 474
Lines 38268 38250 -18
==========================================
- Hits 28937 28919 -18
Misses 7724 7724
Partials 1607 1607
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
55f435a
to
c6fe289
Compare
/approve |
@abhay-krishna: once the present PR merges, I will cherry-pick it on top of release-0.17 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhay-krishna The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@abhay-krishna: new pull request created: #6698 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The Cilium preflight DaemonSet is a part of Cilium Helm charts and is installed to act as helper during Cilium upgrades. Since it's a DaemonSet, it will target all nodes to schedule pods on, and tolerates some well-known taints defined here (this list is a modified version of upstream's list that includes the toleration to the
node-role.kubernetes.io/control-plane
taint). However if a user configures taints in their EKS-A cluster config, then this preflight DaemonSet will not be able to schedule pods on those nodes since it only tolerates the static list of taints above. Thus cluster upgrades will fail during the preflight validation phase when trying to upgrade a cluster with taints.This PR sets the tolerations such that the preflight DaemonSet gets scheduled on all nodes regardless of the taints on that node.
From Kubernetes docs:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.