Backport #6674: Prevent bare metal machine config references from changing to existing machine configs #6686
Conversation
eks-distro-bot
added
the
size/L
|
@chrisdoherty4: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| if desiredDCCfgSpec.OSImageURL != currentDCCfg.Spec.OSImageURL { | ||
| return fmt.Errorf("spec.OSImageURL is immutable. Previous value %s, New value %s", currentDCCfg.Spec.OSImageURL, desiredDCCfgSpec.OSImageURL) | ||
| } |
There was a problem hiding this comment.
In release-0.17 we validate the OSImageURL is unchanged (see removed l.287). In mainline we removed this check to accommodate upgrades to Ubuntu 22.04.
|
/retest |
…g machine configs (#6674)
chrisdoherty4
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-0.17 #6686 +/- ##
===============================================
Coverage ? 75.52%
===============================================
Files ? 455
Lines ? 37934
Branches ? 0
===============================================
Hits ? 28650
Misses ? 7674
Partials ? 1610 ☔ View full report in Codecov by Sentry. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrisdoherty4 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Manual backport of #6674.