Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add regional registries #6681

Merged
merged 1 commit into from
Sep 14, 2023
Merged

Conversation

d8660091
Copy link
Member

@d8660091 d8660091 commented Sep 14, 2023

Issue #, if available:

Description of changes: Add curated packages regional registries for beta stage.

Testing (if applicable):
Manual:

  1. Set EKSA_AWS_* credential environment variables which has access to regional curated package registry
  2. install packagecontroller eksctl-anywhere install packagecontroller
  3. verified the regional registry were used for defaultImageRegistry, defaultRegistry fields of PackageBundleController
  4. verified the packages controller were running healthy, and all its dependencies are healthy
  5. manually installed hello package
  6. verified the hello package was running healthy

Documentation added/planned (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 14, 2023
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Patch coverage: 82.08% and no project coverage change.

Comparison is base (aef8f06) 75.62% compared to head (ae9837a) 75.62%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6681   +/-   ##
=======================================
  Coverage   75.62%   75.62%           
=======================================
  Files         473      474    +1     
  Lines       38265    38213   -52     
=======================================
- Hits        28937    28900   -37     
+ Misses       7728     7712   -16     
- Partials     1600     1601    +1     
Files Changed Coverage Δ
pkg/curatedpackages/regional_registry.go 72.09% <72.09%> (ø)
pkg/curatedpackages/packagecontrollerclient.go 97.34% <100.00%> (+0.11%) ⬆️

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

}

bodyBytes, err := io.ReadAll(resp2.Body)
if resp2.StatusCode != 200 && resp2.StatusCode != 404 {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why aren't we return an error if the StatusCode is 404 here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the function only tests if the customer has the IAM policy, 404 means the customer has it, so 404 is good here

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind adding a comment explaining that? 404 typically means the server cannot find the requested resource, so this confused me a little.

@d8660091
Copy link
Member Author

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: d8660091

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit fc3f71b into aws:main Sep 14, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants