-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add regional registries #6681
Add regional registries #6681
Conversation
cc6e06f
to
856c200
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #6681 +/- ##
=======================================
Coverage 75.62% 75.62%
=======================================
Files 473 474 +1
Lines 38265 38213 -52
=======================================
- Hits 28937 28900 -37
+ Misses 7728 7712 -16
- Partials 1600 1601 +1
☔ View full report in Codecov by Sentry. |
} | ||
|
||
bodyBytes, err := io.ReadAll(resp2.Body) | ||
if resp2.StatusCode != 200 && resp2.StatusCode != 404 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why aren't we return an error if the StatusCode is 404 here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the function only tests if the customer has the IAM policy, 404 means the customer has it, so 404 is good here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mind adding a comment explaining that? 404 typically means the server cannot find the requested resource, so this confused me a little.
8adb6aa
to
34a87f6
Compare
34a87f6
to
ae9837a
Compare
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: d8660091 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issue #, if available:
Description of changes: Add curated packages regional registries for beta stage.
Testing (if applicable):
Manual:
eksctl-anywhere install packagecontroller
Documentation added/planned (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.