Skip to content

Commit

Permalink
fix check for getting etcd url
Browse files Browse the repository at this point in the history
  • Loading branch information
abhinavmpandey08 committed Feb 15, 2024
1 parent 44d1394 commit f669404
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions pkg/providers/common/common.go
Original file line number Diff line number Diff line change
Expand Up @@ -161,12 +161,10 @@ func GetExternalEtcdReleaseURL(clusterVersion string, versionBundle *cluster.Ver
if err != nil {
return "", fmt.Errorf("invalid semver for etcd url enabled clusterVersion: %v", err)
}
devEksaVersion, err := semver.New(v1alpha1.DevBuildVersion)
if err != nil {
return "", fmt.Errorf("invalid semver for dev eksa version: %v", err)
}
if clusterVersionSemVer.Equal(minEksAVersionWithEtcdURL) || clusterVersionSemVer.GreaterThan(minEksAVersionWithEtcdURL) ||
clusterVersionSemVer.Equal(devEksaVersion) {
if !(clusterVersionSemVer.LessThan(minEksAVersionWithEtcdURL)) {
return versionBundle.KubeDistro.EtcdURL, nil
}
logger.V(4).Info(fmt.Sprintf("Eks-a cluster version is less than version %s. Skip setting etcd url", v1alpha1.MinEksAVersionWithEtcdURL))
Expand Down

0 comments on commit f669404

Please sign in to comment.