Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving region check call to correct spot #674

Merged

Conversation

jonahjon
Copy link
Contributor

@jonahjon jonahjon commented Dec 7, 2022

Signed-off-by: jonahjon [email protected]

Issue #, if available:

#658

Description of changes:

The last region check was calling on the staging account for helm charts, we need to move it earlier to query vs the Account which the images live in.

@eks-distro-bot eks-distro-bot added approved size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 7, 2022
Copy link
Contributor

@TerryHowe TerryHowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jonahjon, TerryHowe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit acc58d7 into aws:main Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants