-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding image region check to staging #668
Conversation
Signed-off-by: jonahjon <[email protected]>
generatebundlefile/main.go
Outdated
if err != nil { | ||
BundleLog.Error(err, "getting ECR SDK connection") | ||
os.Exit(1) | ||
} | ||
if err != nil { | ||
BundleLog.Error(err, "error creating ECR client") | ||
os.Exit(1) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
second block is dead code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed in 4a4cbb8
Signed-off-by: jonahjon <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jonahjon, TerryHowe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: jonahjon [email protected]
Issue #, if available:
#658
#627
Description of changes:
Add a check for every image inside the bundle in each region which we support. It will print out any images and their corresponding region which may be missing.