Removing unwanted feature gate(KubeletCredentialProviders) option #1176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eks-distro-bot
added
approved
size/M
|
This PR will address this: aws/eks-anywhere#8984 |
vivek-koppuru
approved these changes
Nov 21, 2024
jhaanvi5
changed the title
jhaanvi5
changed the title
vivek-koppuru
approved these changes
Nov 26, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jhaanvi5, vivek-koppuru The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
jhaanvi5
added a commit
to jhaanvi5/eks-anywhere-packages
that referenced
this pull request
Dec 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
KubeletCredentialProviders.KubeletCredentialProvidersfeature gate was GA'ed in1.26and was removed from1.28. For current supported release versions for EKS-A we don't need to add feature-gate option in kubelet-extra-args since the default option istrueuntil 1.28 and is not available in later release versionsReference: https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates-removed/
Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.