Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improves batch build generation #4138

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

jaxesn
Copy link
Member

@jaxesn jaxesn commented Dec 16, 2024

Issue #, if available:

Description of changes:

The primary goal of this PR to decrease the number of builds the staging build kicks off. The main changes are:

  • released branch builds, cpi-vsphere/bottlerocket-bootstrap/kind, are changed to be based on platform/arch instead of kube version. The instance size is bumped to try and account for the difference in time.
  • the image-builder build in staging only handles the BR artifacts. Those builds have been combined into a single build that downloads an uploads the raw and ova images.
  • the kind build was changed to be by arch with 4 parts, binaries/base images/node images/combine images. This drastically cuts down the number of builds.

Also improved the definition of these batch builds in the makefiles.

  • added a default for the common case which combine images
  • the script figures out the common deps so we dont have to define them in the makefiles. This supports the cases where we break builds up by binary or image platform.
  • better handling of identifier name based on buildspec name

Removes the qemu binfmt install. We should see if we can avoid relying on this and instead just break builds up that need to be run on different archs.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jaxesn. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 16, 2024
@jaxesn jaxesn force-pushed the jgw/batch-cleanup branch 3 times, most recently from 9c08b1a to 96a361d Compare December 17, 2024 04:51
@jaxesn jaxesn changed the title WIP: improves batch build generation improves batch build generation Dec 17, 2024
@eks-distro-bot
Copy link
Collaborator

eks-distro-bot commented Dec 17, 2024

@jaxesn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
cloud-provider-aws-1-30-tooling-presubmit 7661c43 link true /test cloud-provider-aws-1-30-tooling-presubmit
cloud-provider-aws-1-31-tooling-presubmit 7661c43 link true /test cloud-provider-aws-1-31-tooling-presubmit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants