Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IMAGE_OS_VERSION to image-builder buildspecs #3052

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

abhay-krishna
Copy link
Member

Add IMAGE_OS_VERSION to image-builder buildspecs.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 2, 2024
Copy link
Member

@vignesh-goutham vignesh-goutham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@abhay-krishna
Copy link
Member Author

/lgtm
/approve

@eks-distro-bot
Copy link
Collaborator

@abhay-krishna: you cannot LGTM your own PR.

In response to this:

/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhay-krishna, vignesh-goutham

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [abhay-krishna,vignesh-goutham]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit c498167 into aws:main Apr 2, 2024
86 checks passed
@sp1999
Copy link
Member

sp1999 commented Jun 12, 2024

/cherry-pick release-0.19

@eks-distro-pr-bot
Copy link
Contributor

@sp1999: new pull request created: #3297

In response to this:

/cherry-pick release-0.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abhay-krishna abhay-krishna deleted the image-builder-buildspecs branch June 12, 2024 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants