Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert helm version upgrade #3043

Closed
wants to merge 1 commit into from
Closed

Conversation

ahreehong
Copy link
Member

Description of changes:
We removed our patches adding support for the flag --insecure-skip-tls-verify, as the functionality had been added to upstream helm. However, upstream has a bug when using proxy with the --insecure-skip-tls-verify flag so the helm commands fails.

Reverting to the previous version of helm. Will investigate the upstream bug further in a separate ticket.

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from ahreehong. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 30, 2024
@ahreehong ahreehong force-pushed the revert-helm-upgrade branch 2 times, most recently from 7945678 to 5948c19 Compare March 30, 2024 01:06
@ahreehong ahreehong force-pushed the revert-helm-upgrade branch from 5948c19 to 54c4864 Compare March 30, 2024 01:14
@ahreehong
Copy link
Member Author

Created a patch to fix this issue instead of reverting to an older version of helm: #3046

@ahreehong ahreehong closed this Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants