Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use generic parser for kubeadm version check #2925

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Use generic parser for kubeadm version check #2925

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions projects/aws/bottlerocket-bootstrap/CHECKSUMS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
c99005ad01faddc531a7823c703e69aad172a2a76480e0e103347489a33893ba _output/bin/bottlerocket-bootstrap/linux-amd64/bottlerocket-bootstrap
04741f6569abd5ee0fbda4a47fb424c14e9930dbdc665238cc8e27ceb675eb53 _output/bin/bottlerocket-bootstrap/linux-amd64/bottlerocket-bootstrap
1fd36d9a1080f1ec489f0402fec9a7ab6c7cc68ae607babcb82ab55103c53558 _output/bin/bottlerocket-bootstrap/linux-amd64/bottlerocket-bootstrap-snow
65f77aa86aa088ddb3ade1f107e0be93dc65fcefb06045e0c3347a48594557b0 _output/bin/bottlerocket-bootstrap/linux-arm64/bottlerocket-bootstrap
688205c8ed160ba21a8f695d62a3fc98ad1ac344b7ff4df4ad95578286594bb4 _output/bin/bottlerocket-bootstrap/linux-arm64/bottlerocket-bootstrap
9b7d5023b692b488281f8b61aebb46fa7bf50338a4dc224624eac63661f8b65a _output/bin/bottlerocket-bootstrap/linux-arm64/bottlerocket-bootstrap-snow
2 changes: 1 addition & 1 deletion projects/aws/bottlerocket-bootstrap/pkg/kubeadm/controlplane_init.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ func controlPlaneInit() error {
if err != nil {
return errors.Wrapf(err, "Error running command: %v, Output: %s\n", cmd, string(out))
}
kubeadmVersion, err := versionutil.ParseSemantic(strings.TrimSuffix(string(out), "\n"))
kubeadmVersion, err := versionutil.ParseGeneric(strings.TrimSuffix(string(out), "\n"))
if err != nil {
return errors.Wrapf(err, "%s is not a valid kubeadm version", string(out))
}
Expand Down