Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Nutanix Cluster API provider version to v1.3.0 #2912

Closed
wants to merge 1 commit into from

Conversation

adiantum
Copy link
Contributor

@adiantum adiantum commented Feb 9, 2024

Description of changes:
Update Nutanix Cluster API Provider to version v1.3.0
Change cluster-api-provider-nutanix project according to the procedure described in README

Related PR: aws/eks-anywhere#7534

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

 - change cluster-api-provider-nutanix project accoring
   to che procedure described in README
@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign chrisdoherty4 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot
Copy link
Collaborator

Hi @adiantum. Thanks for your PR.

I'm waiting for a aws member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eks-distro-bot eks-distro-bot added needs-ok-to-test size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 9, 2024
@abhay-krishna
Copy link
Member

Hey @adiantum, our project update automation bot has opened #2834 with identical changes, but we held off from merging that until the CCM changes were merged. Can we merge that instead? I am okay with going either way.

@adiantum
Copy link
Contributor Author

adiantum commented Feb 9, 2024

Hey @adiantum, our project update automation bot has opened #2834 with identical changes, but we held off from merging that until the CCM changes were merged. Can we merge that instead? I am okay with going either way.

Hey @abhay-krishna, lets go with #2834.

@adiantum adiantum closed this Feb 9, 2024
@abhay-krishna
Copy link
Member

Hey @adiantum, our project update automation bot has opened #2834 with identical changes, but we held off from merging that until the CCM changes were merged. Can we merge that instead? I am okay with going either way.

Hey @abhay-krishna, lets go with #2834.

Perfect, thanks! I have approved that one, but put it on hold until aws/eks-anywhere#7534 is ready to be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants