Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Autoscaler to latest version for release branch 1-28 #2853

Merged
merged 2 commits into from
Jan 27, 2024

Conversation

rahulbabu95
Copy link
Member

Issue #, if available:
Update Autoscaler chart from 9.21 to 9.34 for release branch 1-28. Combine and merge Helm patches to make it more maintainable.

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 26, 2024
@jonathanmeier5
Copy link
Member

jonathanmeier5 commented Jan 26, 2024

This looks right to me - can we rename the WIP commit here? we should probably also squash all these commits into one. Maybe with a commit message like "Upgrade Cluster Autoscaler 1.28 to Latest"?

@jonathanmeier5
Copy link
Member

/lgtm

@abhay-krishna
Copy link
Member

/lgtm
/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhay-krishna

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit 07f3f36 into aws:main Jan 27, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants