Revert changes to CloudStack output glob #2567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eks-distro-bot
added
the
size/S
abhay-krishna
commented
Oct 17, 2023
| switch b.Os { | ||
| case RedHat: | ||
| outputImageGlobPattern = "output/rhel-*" | ||
| outputImageGlobPattern = "output/rhel-*/rhel-*" |
There was a problem hiding this comment.
This is the fix, rest is just a minor refactor.
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhay-krishna The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "fix" in #2565 actually failed Cloudstack builds because these builds, unlike OVA and Raw image builds, output their final build artifacts in the location
output/build-name/build-name. OVA and Raw also generate similar files in a nestedbuild-namedirectory but due to post processing (compression/archival), the final artifacts end up asoutput/build-name.ovaandoutput/build-name.gz. No such post-processing occurs for cloudstack, so the output artifact is the QCOW2 image inoutput/build-name/build-name(without extension).By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.