Add RHEL support for Nutanix to image-builder #2558
Conversation
- add RHEL8 and RHEL9 support for Nutanix
|
Hi @adiantum. Thanks for your PR. I'm waiting for a aws member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
eks-distro-bot
added
needs-ok-to-test
size/L
|
I'll review this today |
projects/kubernetes-sigs/image-builder/patches/0025-Fix-ensure-iptables-present-for-rhel.patch
Show resolved
Hide resolved
|
|
||
| PACKER_NUTANIX_CONF_FILES=$(MAKE_ROOT)/packer/nutanix/nutanix.json | ||
| PACKER_NUTANIX_VAR_FILES+=$(PACKER_NUTANIX_CONF_FILES) | ||
| PACKER_NUTANIX_VAR_FILES?= |
There was a problem hiding this comment.
we made this change after bumping to the latest image-builder release tag because it started validated the nutanix settings. I was curious about why this started and if this change would cause issues. How are you avoiding the validation error now without this change?
There was a problem hiding this comment.
We're providing nutanix settings to AWS image-builder with --nutanix-config option. nutanix-config is json file with the same params like in nutanix.json
For example:
$ cat ./nutanix-connection-rhel-9.json
{
"nutanix_cluster_name": "e2e***",
"source_image_name": "rhel-9.2-x86_64-kvm.qcow2",
"image_url": "http://data.***/rhel-9.2-x86_64-kvm.qcow2",
"image_name": "eksa-rhel-9-kube-1-27",
"nutanix_subnet_name": "vlan***",
"nutanix_endpoint": "prism-ncn-ci.***",
"nutanix_insecure": "false",
"nutanix_port": "9440",
"nutanix_username": "***",
"nutanix_password": "***",
"rhel_username": "***",
"rhel_password": "****"
}
JFYI: I've tested it with the following command:
CODEBUILD_CI=true CODEBUILD_SRC_DIR=/***/eks-anywhere-build-tooling REPO_NO_CLONE=true ./image-builder build --os redhat --os-version 9 --hypervisor nutanix --release-channel 1-27 --nutanix-config ./nutanix-connection-rhel-9.json -v 20
There was a problem hiding this comment.
yeah thats kind of what I figured. Its possible its just a presubmit issue. let me enable the tests and lets see what it does.
There was a problem hiding this comment.
Yeah, it's failed on presubmit, but if we don't revert it then image-builder failed to work with nutanix clusters. I have an idea how to fix it, return in short time after testing both cases.
.../kubernetes-sigs/image-builder/patches/0023-Nutanix-RHEL-support-for-AWS-image-builder.patch
Show resolved
Hide resolved
|
/ok-to-test |
| fmt.Sprintf("%s=%s", rhelUsernameEnvVar, b.NutanixConfig.RhelUsername), | ||
| fmt.Sprintf("%s=%s", rhelPasswordEnvVar, b.NutanixConfig.RhelPassword), | ||
| fmt.Sprintf("%s=%s", rhelImageUrlNutanixEnvVar, b.NutanixConfig.ImageUrl), | ||
| fmt.Sprintf("%s=%s", "PACKER_NUTANIX_TEST_CONF_FILES", " "), |
There was a problem hiding this comment.
im thinking maybe something like this instead?
thats what we do for cloudstack and baremetal. cc @abhay-krishna
There was a problem hiding this comment.
@jaxesn I've changed it in similar way like cloudstack and baremetal.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jaxesn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description of changes:
Add RHEL8 and RHEL9 images support for Nutanix
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.