Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL overrides for bundles and EKS-D manifest for air gapped Image builder #2549

Merged
merged 2 commits into from
Oct 16, 2023

Conversation

vignesh-goutham
Copy link
Member

Description of changes:*
Image builder when running in air gapped mode, will set an override for EKS-D manifest and EKS-A bundles manifest that will house artifacts pointing to the internal artifacts server.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 12, 2023
@abhay-krishna
Copy link
Member

/lgtm
/approve

build/lib/eksa_releases.sh Show resolved Hide resolved
@vignesh-goutham
Copy link
Member Author

/test cloud-provider-aws-1-23-tooling-presubmit

@abhay-krishna
Copy link
Member

/lgtm
/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhay-krishna

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@abhay-krishna
Copy link
Member

/retest

@eks-distro-bot eks-distro-bot merged commit f94e440 into aws:main Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants