Skip to content

Commit

Permalink
feat(e2e): update max retry time for http get
Browse files Browse the repository at this point in the history
ALBs somtimes take more than 10 seconds to consistently
resolve a new route. This change should make our tests
more stable by giving them up to 30s to resolve.
  • Loading branch information
kohidave committed Mar 17, 2020
1 parent bfb6121 commit c50eb78
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion e2e/init/init_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ var _ = Describe("init flow", func() {
Eventually(func() (int, error) {
resp, fetchErr := http.Get(app.Routes[0].URL)
return resp.StatusCode, fetchErr
}, "10s", "1s").Should(Equal(200))
}, "30s", "1s").Should(Equal(200))
})

It("should return the correct environment variables", func() {
Expand Down
2 changes: 1 addition & 1 deletion e2e/multi-app-project/multi_app_project_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ var _ = Describe("Multiple App Project", func() {
Eventually(func() (int, error) {
resp, fetchErr = http.Get(route.URL)
return resp.StatusCode, fetchErr
}, "10s", "1s").Should(Equal(200))
}, "30s", "1s").Should(Equal(200))

// Read the response - our deployed apps should return a body with their
// name as the value.
Expand Down
2 changes: 1 addition & 1 deletion e2e/multi-env-project/multi_env_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ var _ = Describe("Multiple Env Project", func() {
Eventually(func() (int, error) {
resp, fetchErr := http.Get(route.URL)
return resp.StatusCode, fetchErr
}, "10s", "1s").Should(Equal(200))
}, "30s", "1s").Should(Equal(200))
}
})

Expand Down

0 comments on commit c50eb78

Please sign in to comment.