Skip to content

Commit

Permalink
chore(e2e): change the alias used by app-with-domain (#4930)
Browse files Browse the repository at this point in the history
Because it clashes with the alias used by `imported-cert` causing transient error sometimes.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.
  • Loading branch information
Lou1415926 authored May 24, 2023
1 parent 282acb7 commit 88a2478
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 8 deletions.
6 changes: 3 additions & 3 deletions e2e/app-with-domain/app_with_domain_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -249,8 +249,8 @@ var _ = Describe("App With Domain", func() {
Expect(len(svc.Routes)).To(Equal(2))

wantedURLs := map[string]string{
"test": "https://test.copilot-e2e-tests.ecs.aws.dev",
"prod": "https://prod.copilot-e2e-tests.ecs.aws.dev",
"test": "https://hello-test-app-domain.copilot-e2e-tests.ecs.aws.dev",
"prod": "https://hello-prod-app-domain.copilot-e2e-tests.ecs.aws.dev",
}
for _, route := range svc.Routes {
// Validate route has the expected HTTPS endpoint.
Expand Down Expand Up @@ -278,7 +278,7 @@ var _ = Describe("App With Domain", func() {
Expect(err).NotTo(HaveOccurred())
Expect(len(svc.Routes)).To(Equal(1))
wantedURLs = map[string]string{
"test": "https://copilot-e2e-tests.ecs.aws.dev or https://frontend.copilot-e2e-tests.ecs.aws.dev",
"test": "https://copilot-e2e-tests.ecs.aws.dev or https://frontend-app-domain.copilot-e2e-tests.ecs.aws.dev",
}
// Validate route has the expected HTTPS endpoint.
route := svc.Routes[0]
Expand Down
2 changes: 1 addition & 1 deletion e2e/app-with-domain/copilot/frontend/manifest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ image:

http:
path: '/'
alias: ["frontend.copilot-e2e-tests.ecs.aws.dev", "copilot-e2e-tests.ecs.aws.dev"]
alias: ["frontend-app-domain.copilot-e2e-tests.ecs.aws.dev", "copilot-e2e-tests.ecs.aws.dev"]

cpu: 256
memory: 512
Expand Down
4 changes: 2 additions & 2 deletions e2e/app-with-domain/copilot/hello/manifest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ image:

http:
path: '/'
alias: test.copilot-e2e-tests.ecs.aws.dev
alias: hello-test-app-domain.copilot-e2e-tests.ecs.aws.dev

cpu: 256
memory: 512
Expand All @@ -18,4 +18,4 @@ count: 1
environments:
prod:
http:
alias: prod.copilot-e2e-tests.ecs.aws.dev
alias: hello-prod-app-domain.copilot-e2e-tests.ecs.aws.dev
2 changes: 1 addition & 1 deletion e2e/import-certs/copilot/frontend/manifest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ image:

http:
path: '/'
alias: "test.copilot-e2e-tests.ecs.aws.dev"
alias: "frontend-test-imported-cert.copilot-e2e-tests.ecs.aws.dev"
hosted_zone: "Z0512687YJJFTKMRQUQR"

cpu: 256
Expand Down
2 changes: 1 addition & 1 deletion e2e/import-certs/import_cert_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ var _ = Describe("Import Certificates", func() {
Expect(len(svc.Routes)).To(Equal(1))

wantedURLs := map[string]string{
"test": "https://test.copilot-e2e-tests.ecs.aws.dev",
"test": "https://frontend-test-imported-cert.copilot-e2e-tests.ecs.aws.dev",
}
for _, route := range svc.Routes {
// Validate route has the expected HTTPS endpoint.
Expand Down

0 comments on commit 88a2478

Please sign in to comment.