Skip to content

Commit

Permalink
chore: make app delete default to no in confirmation prompt (#5267)
Browse files Browse the repository at this point in the history
Quick fix to address #5258. We shouldn't default to "yes" on app delete confirmation, as that makes it easy to destroy apps with an errant keypress.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.
  • Loading branch information
bvtujo authored Aug 31, 2023
1 parent 7e7c59a commit 3a73f6e
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion internal/pkg/cli/app_delete.go
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,6 @@ func (o *deleteAppOpts) Ask() error {
manualConfirm, err := o.prompt.Confirm(
fmt.Sprintf(fmtDeleteAppConfirmPrompt, o.name),
deleteAppConfirmHelp,
prompt.WithTrueDefault(),
prompt.WithConfirmFinalMessage())
if err != nil {
return fmt.Errorf("confirm app deletion: %w", err)
Expand Down

0 comments on commit 3a73f6e

Please sign in to comment.