Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update codecov upload using GH Actions #692

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Update codecov upload using GH Actions #692

merged 1 commit into from
Oct 14, 2024

Conversation

jj22ee
Copy link
Contributor

@jj22ee jj22ee commented Oct 14, 2024

Issue #, if available:
This PR addresses issue in: #688
This is blocking all PRs from succeeding the PR checks.

Description of changes:

  1. Remove use of codecov cli command in core's package.json (used to upload codecov report)
  2. Add codecov/codecov-action@v4 action to upload codecov report of the core package.

Testing:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jj22ee jj22ee requested a review from a team as a code owner October 14, 2024 19:49
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.56%. Comparing base (5539f1a) to head (1fd4d39).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #692      +/-   ##
==========================================
- Coverage   83.57%   83.56%   -0.01%     
==========================================
  Files          37       36       -1     
  Lines        1814     1813       -1     
==========================================
- Hits         1516     1515       -1     
  Misses        298      298              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jj22ee jj22ee changed the title [DRAFT] Update codecov upload Update codecov upload using GH Actions Oct 14, 2024
Copy link
Contributor

@wangzlei wangzlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jj22ee jj22ee merged commit 9552603 into master Oct 14, 2024
13 checks passed
This was referenced Oct 14, 2024
@jj22ee jj22ee deleted the codecov-upgrade branch October 14, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants