-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(credential-providers): make credential providers aware of caller client region #6726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
kuhe
force-pushed
the
feat/credentials-context
branch
2 times, most recently
from
December 12, 2024 20:11
5bc2b69
to
7c97498
Compare
kuhe
changed the title
feat(credential-providers): make credential providers aware of contextual client region
feat(credential-providers): make credential providers aware of caller client region
Dec 12, 2024
trivikr
reviewed
Dec 12, 2024
packages/core/src/submodules/httpAuthSchemes/aws_sdk/resolveAwsSdkSigV4Config.ts
Outdated
Show resolved
Hide resolved
packages/credential-provider-ini/src/resolveAssumeRoleCredentials.ts
Outdated
Show resolved
Hide resolved
kuhe
force-pushed
the
feat/credentials-context
branch
from
December 12, 2024 20:58
6c470e9
to
c8ab6fa
Compare
trivikr
approved these changes
Dec 13, 2024
…tual client region
…sSdkSigV4Config.ts Co-authored-by: Trivikram Kamat <[email protected]>
kuhe
force-pushed
the
feat/credentials-context
branch
from
December 13, 2024 19:47
c8ab6fa
to
90d7122
Compare
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously introduced the concept of a "parentClientConfig" for credential providers that create another (inner) SDK client such as STS.
One problem was that if the provider was initialized outside of a client, this association between the client and credential provider function could not be made. This PR makes AWS credential providers accept a contextual client config, making them region aware at call time. The result is improved intuitiveness of default behavior, as shown below.
currently
fromIni
is a standalone function that can resolve credentials without the context of an SDK client.in this PR
Improved intuitiveness of credentials region resolution.