test(client-ec2): convert cucumber tests to vitest for ec2 #6625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuhe
commented
Nov 5, 2024
| // await waitUntilSnapshotCompleted( | ||
| // { client: dstEc2, maxWaitTime: 20 }, | ||
| // { | ||
| // SnapshotId: copySnapshot.SnapshotId, |
There was a problem hiding this comment.
this waiter call was wrong, which is why it didn't work. Revealed by TypeScript.
kuhe
commented
Nov 5, 2024
| await waitUntilSnapshotCompleted( | ||
| { client: srcEc2, maxWaitTime: 300 }, | ||
| { | ||
| SnapshotId: createSnapshot.SnapshotId, |
There was a problem hiding this comment.
this waiter also had the same typo, but for whatever reason passed. Must be a false positive, with SnapshotIds[] considered empty and passing.
trivikr
approved these changes
Nov 5, 2024
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
n/a
Description
Converts the cucumber tests for ec2 into Vitest and places them in the ec2 middleware package (the tests mainly cover what is in the middleware package, not the client itself).
Benefits:
Testing
Ran the tests in the PR.
Checklist