Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(codegen): accIdEpMode config resolver generation plugin #6544

Merged
merged 7 commits into from
Oct 4, 2024

Conversation

siddsriv
Copy link
Contributor

@siddsriv siddsriv commented Oct 4, 2024

Description

  • generate config resolver for accId (as runtime plugin)
  • complete previous TODOs for this codegen: adding addImportSubmodule in lieu of addImport for @aws-sdk/core/account-id-endpoint
  • updated ddb client
  • formatting fixes for accIdEpMode typescript integration

Testing

for:

const ddbClient = new DynamoDBClient({ region: REGION, accountIdEndpointMode: "blah" });

the resolver throws:

Error: Invalid value for accountIdEndpointMode: blah. Valid values are: "required", "preferred", "disabled".
    at accountIdEndpointMode (/local/home/sidddsri/workspace/aws-sdk-js-v3/packages/core/dist-cjs/submodules/account-id-endpoint/index.js:55:15)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@siddsriv siddsriv requested a review from a team as a code owner October 4, 2024 16:01
@siddsriv siddsriv marked this pull request as draft October 4, 2024 16:09
@siddsriv siddsriv marked this pull request as ready for review October 4, 2024 17:01
@siddsriv siddsriv merged commit fc14586 into aws:main Oct 4, 2024
5 checks passed
@siddsriv siddsriv deleted the fix/accConfig branch October 4, 2024 17:38
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants