Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(middleware-compression): add missing @aws-sdk prefix in package name #5627

Merged
merged 2 commits into from
Dec 29, 2023

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Dec 29, 2023

Issue

Internal JS-4947

Description

Adds missing @AWS-SDK prefix in package name, along with CHANGLOG and docs generation config/commands.

Testing

Verified that test:size is successful

$ yarn test:size --since last_release
...
Updating 45 rows in the report /local/home/trivikr/workspace/aws-sdk-js-v3/benchmark/size/report.md
Report is updated, validating the new result with the limit configurations.
Done in 542.39s.

Checklist

  • If you wrote E2E tests, are they resilient to concurrent I/O?
  • If adding new public functions, did you add the @public tag and enable doc generation on the package?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr requested a review from a team as a code owner December 29, 2023 20:12
@trivikr trivikr merged commit 8b874f7 into aws:main Dec 29, 2023
3 checks passed
@trivikr trivikr deleted the middleware-compression-update branch December 29, 2023 20:33
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants