Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MSRV to 1.68.2 #596

Merged
merged 3 commits into from
Mar 20, 2024
Merged

Update MSRV to 1.68.2 #596

merged 3 commits into from
Mar 20, 2024

Conversation

meerd
Copy link
Contributor

@meerd meerd commented Mar 20, 2024

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

meerd added 3 commits March 19, 2024 02:14
Update minimum supported rust version (MSRV) to 1.68.2.

Signed-off-by: Erdem Meydanli <[email protected]>
Migrate from checkout@v3 to checkout@v4.

Signed-off-by: Erdem Meydanli <[email protected]>
Copy link
Contributor

@eugkoira eugkoira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: not clear why Migrate from checkout@v3 to checkout@v4 commit is needed for rust bump here

@meerd
Copy link
Contributor Author

meerd commented Mar 20, 2024

nit: not clear why Migrate from checkout@v3 to checkout@v4 commit is needed for rust bump here

For efficiency reasons, I wanted to eliminate the GitHub Actions warnings caused by using checkout@v3, and avoid creating a new pull request.

@meerd meerd merged commit 957ac21 into aws:main Mar 20, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants