Revisit the command-executer workspace #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ust 1.60 for Clippy Recently, the dtolnay/rust-toolchain action was updated to Rust 1.75. Because of this, we have lots of warnings generated for Clippy on any new changes. Let's restrict dtolnay/rust-toolchain to Rust 1.60 temporarily. Signed-off-by: Costin Lupu <[email protected]>
... instead of defining a separate workspace for it. With this occasion we also need to update Cargo.lock with the new dependencies. Signed-off-by: Costin Lupu <[email protected]>
Adding command-executer as a workspace member brings the advantage of including the component for Clippy scanning. Signed-off-by: Costin Lupu <[email protected]>
clupuishere
changed the title
meerd
approved these changes
Jan 4, 2024
mariusknaust
approved these changes
Jan 4, 2024
|
Created an issue for tracking the revert of dtolnay/rust-toolchain action to stable: #574. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.