SPECS/aws-nitro-enclaves-cli.spec: Do not mangle shebangs #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The package builder used for Amazon Linux 2023 mangles shebangs in the packaged scripts, but the new paths may not exist for scripts whose target environment is not Amazon Linux based. For example, in the case of `hello.sh` which is meant to be run in a Docker container, the shebang is rewritten from `#!/bin/sh` to `#!/usr/bin/sh`, but the latter path does not exist. This has the effect of preventing the "Hello Enclave" enclave from being instantiated. Therefore we disable shebang mangling for the scripts from the examples. Signed-off-by: Costin Lupu <[email protected]>
clupuishere
force-pushed
the
dont-mangle
branch
from
5a05f8b to
2762534
Compare
mariusknaust
approved these changes
Nov 14, 2023
eugkoira
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The package builder used for Amazon Linux 2023 mangles shebangs in the packaged scripts, but the new paths may not exist. For example, in the case of
hello.sh, the shebang is rewritten from#!/bin/shto#!/usr/bin/sh, but the latter path does not exist. This has the effect of preventing the "Hello Enclave" enclave from being instantiated. Therefore we disable shebang mangling for the entire package.Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.