Add integration patches/CI for Ruby main and 3.3 #2071
+1,381
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2071 +/- ##
==========================================
+ Coverage 78.95% 78.96% +0.01%
==========================================
Files 610 610
Lines 105293 105294 +1
Branches 14911 14920 +9
==========================================
+ Hits 83129 83143 +14
+ Misses 21511 21500 -11
+ Partials 653 651 -2 ☔ View full report in Codecov by Sentry. |
samuel40791765
force-pushed
the
ruby-integration-main
branch
2 times, most recently
from
e146fd0 to
584efab
Compare
|
Per a recent test run, it looks like we need to implement Even when under review, these integration tests help us respond to upstream changes :) |
Are we planning to submit a PR upstream to Ruby? |
|
Ahh I'll put up a PR to add support for
Yeah I've submitted a PR upstream and cut an issue to GnuTLS as well. ruby/openssl#830 |
samuel40791765
force-pushed
the
ruby-integration-main
branch
from
abf9d23 to
a9d4a6e
Compare
samuel40791765
force-pushed
the
ruby-integration-main
branch
from
a9d4a6e to
3e0243d
Compare
samuel40791765
added a commit
that referenced
this pull request
Jan 22, 2025
Ruby's made a couple larger refactors to require versions later than OpenSSL 1.1.1. These changes require us to make a few tweaks to the patch in #2071 and have exposed a couple minor symbols that we don't support. Adding support for the ones that aren't complicated in this commit. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.
samuel40791765
force-pushed
the
ruby-integration-main
branch
2 times, most recently
from
c8eda30 to
01e7f25
Compare
samuel40791765
force-pushed
the
ruby-integration-main
branch
from
01e7f25 to
3ee9bb3
Compare
manastasova
pushed a commit
to manastasova/aws-lc
that referenced
this pull request
Jan 30, 2025
Ruby's made a couple larger refactors to require versions later than OpenSSL 1.1.1. These changes require us to make a few tweaks to the patch in aws#2071 and have exposed a couple minor symbols that we don't support. Adding support for the ones that aren't complicated in this commit. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Resolves
CryptoAlg-2784Description of changes:
Ruby 3.3 is relatively the same as 3.2 with just one more test failure due to conflicting error messages.
Ruby's master branch has added much more however.
test/openssl/pkey_rsa.rbgenerated by certtool isn't parsable by us. I've pinned down the reason to a missingNULLfield in the ASN1 contents. I've cut an issue to gnutls, more details can be found there.I've replaced the file that Ruby's been using for the time being and replaced the original generation to use OpenSSL instead. OpenSSL's PKCS8 files adhere to the RFC.
Call-outs:
N/A
Testing:
New CI
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.