Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend aws region validation #430

Merged
merged 4 commits into from
Jun 4, 2024
Merged

Extend aws region validation #430

merged 4 commits into from
Jun 4, 2024

Conversation

xiazhvera
Copy link
Contributor

@xiazhvera xiazhvera commented Jun 3, 2024

Issue #, if available:

Description of changes:
Now the SDK would extract any pattern between "iot." and ".amazonaws" as region.
For example: "XXXX.iot.test-region-value.amazonaws.com". If the region is not specified, the device would use 'test-region-value' as the region option.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@xiazhvera xiazhvera changed the title Allow extra aws regions Extend aws region validation Jun 3, 2024
device/index.js Outdated Show resolved Hide resolved
@xiazhvera xiazhvera merged commit a8c734f into master Jun 4, 2024
4 checks passed
@xiazhvera xiazhvera deleted the extend_region branch June 4, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants