-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Telegram Notification Lambda function #1
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall looks pretty good, aside from the specific comments, I'd suggest passing your code through flake8 to cleanup the few (often pedantic) style issues it reports
|
||
logger.info(str(msg)) | ||
|
||
req = Request(API_ENDPOINT, urllib.urlencode(msg)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
using the requests module here will probably be more concise, and probably more familiar to python coders.
as an added plus there's no need to bundle the lib in your deployment package as it's included in botocore:
import botocore.vendored.requests as requests
@@ -0,0 +1,40 @@ | |||
from __future__ import print_function | |||
|
|||
import boto3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
boto3, json and os modules are being imported without being needed
File references something which is not present
Update risk_credentials_exposed.serverless.yaml with all possible eve…
Added Telegram Notification Lambda function