This repository has been archived by the owner on May 31, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 83
fix: temporary MANIFEST.json is created and combined with file path from --inputsFile #527
Open
sonjand
wants to merge
15
commits into
aws:main
Choose a base branch
from
sonjand:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lingjiekong
reviewed
Oct 11, 2022
lingjiekong
reviewed
Oct 11, 2022
lingjiekong
reviewed
Oct 11, 2022
lingjiekong
reviewed
Oct 13, 2022
lingjiekong
reviewed
Oct 17, 2022
lingjiekong
reviewed
Oct 17, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: 474
Description of Changes
added new function
parseAndAddToManifest()
that allows users to use a MANIFEST.json file and include a file with the --inputsFile flag without any overriding.Description of how you validated changes
Various calls of
make
andworkflow run
were used to test creation of new file, as well as its eventual deletion.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license