Skip to content
This repository has been archived by the owner on May 31, 2024. It is now read-only.

fix: temporary MANIFEST.json is created and combined with file path from --inputsFile #527

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

sonjand
Copy link

@sonjand sonjand commented Oct 10, 2022

Issue #, if available: 474

Description of Changes

added new function parseAndAddToManifest()that allows users to use a MANIFEST.json file and include a file with the --inputsFile flag without any overriding.

Description of how you validated changes

Various calls of make and workflow run were used to test creation of new file, as well as its eventual deletion.

Checklist

  • If this change would make any existing documentation invalid, I have included those updates within this PR
  • I have added unit tests that prove my fix is effective or that my feature works
  • I have linted my code before raising the PR
  • Title of this Pull Request follows Conventional Commits standard: https://www.conventionalcommits.org/en/v1.0.0/

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

packages/cli/internal/pkg/cli/workflow/manager.go Outdated Show resolved Hide resolved
packages/cli/internal/pkg/cli/workflow/manager.go Outdated Show resolved Hide resolved
packages/cli/internal/pkg/cli/workflow/manager.go Outdated Show resolved Hide resolved
packages/cli/internal/pkg/cli/workflow/manager.go Outdated Show resolved Hide resolved
packages/cli/internal/pkg/cli/workflow/manager.go Outdated Show resolved Hide resolved
packages/cli/internal/pkg/cli/workflow/manager.go Outdated Show resolved Hide resolved
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants