This repository has been archived by the owner on May 31, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 83
feat: Added option to pass custom WES Adapter environment variables #420
Open
kankou-aliaksei
wants to merge
14
commits into
aws:main
Choose a base branch
from
kankou-aliaksei:custom-wes-environment-vars
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: Added option to pass custom WES Adapter environment variables #420
kankou-aliaksei
wants to merge
14
commits into
aws:main
from
kankou-aliaksei:custom-wes-environment-vars
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
markjschreiber
previously approved these changes
Apr 29, 2022
markjschreiber
previously approved these changes
Apr 29, 2022
# Conflicts: # packages/cli/internal/pkg/cli/context/manager_deploy_test.go
markjschreiber
previously approved these changes
May 10, 2022
markjschreiber
approved these changes
May 12, 2022
Looking forward to this so I can set config options as per chanzuckerberg/miniwdl#570 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: #396
Description of Changes
[//]: # This adds option to pass custom environment variables into WES Adapter
[//]: # This adds option to pass custom environment variables into Workflow Job
Description of how you validated changes
[//]: # Add configuration for context
[//]: # Deploy context agc context deploy --context miniContext
[//]: # After context deploying a WES Adapter Lambda must have k1 and CUSTOM_WORKFLOW_JOB_ENV_VARS env vars
[//]: # After agc workflow run hello --context miniContext go to Batch Workflow Job Logs and find MINIWDL__AWS__BOTO3_RETRIES, MINIWDL__AWS__DESCRIBE_PERIOD, MINIWDL__AWS__SUBMIT_PERIOD vars under === ENVIRONMENT === section
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license