Add global-bundle.pem to default cert list and Implement Dynamic .taco Filename Handling #571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 17, 2024 17:01
- Removed rds-ca-2019-root.pem as it is included in global-bundle.pem. - This change simplifies the certificate management in the JDBC driver.
This comment has been minimized.
This comment has been minimized.
CassieLyu
approved these changes
Apr 22, 2024
sunnie629
reviewed
Apr 23, 2024
sunnie629
approved these changes
Apr 23, 2024
This comment has been minimized.
This comment has been minimized.
1 similar comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add Global Certificate to Enhance Connection Stability with Tableau and Modify script to dynamic .taco filname handling in build script
Description
This pull request addresses a recent issue where customers experienced connection problems using Tableau Desktop to connect to clusters authenticated with the new
rds-ca-rsa2048-g1CA certificate. To resolve this, the following changes have been implemented in the JDBC driver repository:global-bundle.pemto the default certificate list. This bundle includes the latest CA certificates, ensuring broader compatibility and trust chain completeness.rds-ca-2019-root.pemfrom the certificate list. This certificate is redundant as its contents are already included in theglobal-bundle.pem, streamlining the certificate management process..tacoFilename Handling: Updated the build script to accommodate changes in the naming convention of.tacofiles generated by Tableau's Connector SDK. Previously hardcoded references to the.tacofile have been replaced with a dynamic lookup mechanism. This ensures the script robustly handles new versions of.tacofiles without manual updates, enhancing maintainability and reducing potential for errors during builds.Related Issue
Additional Reviewers
@CassieLyu
@sunnie629
@affonsoBQ
@alinaliBQ
@andiem-bq
@alexey-temnikov
@birschick-bq