Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Serverless pattern for ECS and EFS Integration using terraform #1853

Merged

Conversation

nj80750
Copy link
Contributor

@nj80750 nj80750 commented Nov 7, 2023

Issue #, if available: 1854

Description of changes:
Added terraform code, a sample docker file a sample bash script which will run inside the container

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

github-actions bot commented Nov 9, 2023

@nj80750 looks like you are missing the example-pattern.json file in your pattern.

You can find the example-pattern template here.

The file is used on ServerlessLand and is required. Once the file is added we can review the pattern.

Copy link

@nj80750 your 'example-pattern.json' is missing some key fields, please review below and address any errors you have

  1. gitHub.template: gitHub.template requires property "projectFolder"

If you need any help, take a look at the example-pattern file.

Make the changes, and push your changes back to this pull request. When all automated checks are successful, the Serverless DA team will process your pull request.

@julianwood
Copy link
Contributor

Please can you provide a more comprehensive README with instructions as how to deploy the pattern, what example values to enter for the Terraform variables and how to then test the pattern works once deployed.

@julianwood julianwood merged commit 57931f3 into aws-samples:main Dec 6, 2023
1 of 2 checks passed
@nj80750 nj80750 deleted the nj80750-feature-ecs-efs-integration branch December 11, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants