LP 改善 #146
Merged
LP 改善 #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbrand
commented
Nov 2, 2023
| imageGenModelName: process.env.IMAGE_GEN_MODEL_NAME, | ||
| }), | ||
| }; | ||
| }; |
There was a problem hiding this comment.
無駄に Frontend に読ませる環境変数を増やしたくなかったため、設定をとれる API を生やしました
wadabee
reviewed
Nov 2, 2023
| {!isLoading && !error && setting && ( | ||
| <> | ||
| <div className="flex w-full flex-col items-center text-sm"> | ||
| <SettingItem name="LLM モデルタイプ" value={setting.modelType} /> |
There was a problem hiding this comment.
「設定情報」の存在に気づかないかなと思いました。
左下にメニュー的なもの用意する、ヘッダ部分にいい感じで表示するという代替案があるかなと思います！
There was a problem hiding this comment.
メニュー的なもの or いい感じにというのがわからないので、具体的に教えてください！設定ボタンつけて独立ページに移行すれば良いですか？
| {setting.modelType === 'bedrock' && ( | ||
| <div className="mt-5 w-2/3 text-xs xl:w-1/3"> | ||
| ユースケース実行時にエラーになる場合は、必ず{' '} | ||
| <span className="font-bold">{setting.modelRegion}</span> にて{' '} |
There was a problem hiding this comment.
空文字を使ってスペーシングしていますが、CSSのmarginのほうが良いかなと思いました。
There was a problem hiding this comment.
英単語の前後に半角スペース入れて npm run lint したら勝手にこうなったんですよね。消しておきます。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#125
#100