new: Added a new lab 'Mountpoint for S3' #1176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s to be copied from retail store image into assets container
…access mountpoint by altering PV permissions
…nd then attaching mountpoint to pods
add mountpoint for s3 workshop content - contains placeholder content to change assets at a later date
updated workshop content.
updated revision that includes feedback from offline review
updated assets-s3.webp to reflect S3 architecture diagram instead of EFS architecture diagram
Updated workshop flow to simplify a command
removed a copy + paste typo
✅ Deploy Preview for eks-workshop ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
heinrichse
previously approved these changes
Nov 4, 2024
heinrichse
previously approved these changes
Nov 4, 2024
heinrichse
previously approved these changes
Nov 5, 2024
pengc99
reviewed
Nov 15, 2024
niallthomson
requested changes
Nov 15, 2024
|
|
||
| First inspect the `s3pvclaim.yaml` file to see the parameters in the file and the claim: | ||
|
|
||
| ```file |
There was a problem hiding this comment.
Instead of displaying the file with comments please use the component we have specifically for explaining YAML files https://github.com/aws-samples/eks-workshop-v2/blob/main/docs/ui_components.md#yaml-file
There was a problem hiding this comment.
| assets-9fbbbcd6f-lb46c 1/1 Running 0 6m55s | ||
| ``` | ||
|
|
||
| Finally, let's take a look at our final deployment with the Mountpoint for Amazon S3 CSI driver: |
There was a problem hiding this comment.
I don't think its necessary to show the whole deployment, its a lot of text with no explanation.
There was a problem hiding this comment.
|
|
||
| We can start by describing the Deployment to take a look at its initial volume configuration: | ||
|
|
||
| ```bash |
There was a problem hiding this comment.
I think we can shorten the amount of information here, its a lot not related to the volumes etc.
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
EKS Workshop can benefit greatly from a module that showcases the use of Mountpoint for S3. This content is placed under the Fundamentals/Storage exercises.
Which issue(s) this PR fixes: Fixes #843
Quality checks
make test module="fundamentals/storage/mountpoint-s3"it was successful (see https://github.com/aws-samples/eks-workshop-v2/blob/main/docs/automated_tests.md)By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.