-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update: Changes to EKS cluster logging instructions #1059
Conversation
✅ Deploy Preview for eks-workshop ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
I'm having difficulty breaking down exactly what this is changing due to the fact its images. Can you describe the changes you made? |
The document file was missed. Changes made are on the screen shot. Updated the screens to point to how to enable control pane logging through console |
The changes are to show the user that about observability tooling and highlight the ability to enable control plane logs without code and using console. We retained the use of Api as well. |
Reviewed, changes look good, but branch is out-of-date, please merge |
Back merge from main
Took the latest from master. Branch should be up to date |
Approved, looks good to me. |
What this PR does / why we need it:
This fixes the issue 978. Changing the content for observability to point to console.
Updating with the latest console screens
Which issue(s) this PR fixes:
Fixes # #978
Quality checks
make test module="<module>"
it was successful (see https://github.com/aws-samples/eks-workshop-v2/blob/main/docs/automated_tests.md)By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.