Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: Changes to EKS cluster logging instructions #1059

Merged
merged 4 commits into from
Sep 26, 2024

Conversation

kathanjit
Copy link
Contributor

What this PR does / why we need it:

This fixes the issue 978. Changing the content for observability to point to console.
Updating with the latest console screens

Which issue(s) this PR fixes:

Fixes # #978

Quality checks

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@kathanjit kathanjit requested a review from a team as a code owner August 28, 2024 12:45
Copy link

netlify bot commented Aug 28, 2024

Deploy Preview for eks-workshop ready!

Name Link
🔨 Latest commit a5a8341
🔍 Latest deploy log https://app.netlify.com/sites/eks-workshop/deploys/66f5e64e7d1d120008f99736
😎 Deploy Preview https://deploy-preview-1059--eks-workshop.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kathanjit kathanjit changed the title Fixing EKS control plane looging content for issue-978 Fixing EKS control plane logging content for issue-978 Aug 28, 2024
@niallthomson
Copy link
Contributor

I'm having difficulty breaking down exactly what this is changing due to the fact its images. Can you describe the changes you made?

@kathanjit
Copy link
Contributor Author

The document file was missed. Changes made are on the screen shot. Updated the screens to point to how to enable control pane logging through console

@jsgoudar
Copy link
Contributor

jsgoudar commented Sep 6, 2024

I'm having difficulty breaking down exactly what this is changing due to the fact its images. Can you describe the changes you made?

The changes are to show the user that about observability tooling and highlight the ability to enable control plane logs without code and using console. We retained the use of Api as well.

@jsgoudar
Copy link
Contributor

jsgoudar commented Sep 6, 2024

Reviewed, changes look good, but branch is out-of-date, please merge

@kathanjit
Copy link
Contributor Author

Took the latest from master. Branch should be up to date

@jsgoudar
Copy link
Contributor

Approved, looks good to me.

@niallthomson niallthomson changed the title Fixing EKS control plane logging content for issue-978 update: Changes to EKS cluster logging instructions Sep 26, 2024
@niallthomson niallthomson added this to the Release 09/27 milestone Sep 26, 2024
@niallthomson niallthomson merged commit 1a76627 into aws-samples:main Sep 26, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants