Added training plan logic into automate script #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To avoid confusion, modified pre-requisites output at begining of script to clearly state what resources have been pre-provisioned by workshop studio. The AIM_403 branch of this script presumes a workshop studio account has been deployed and a user is running on a SageMaker studio Code instance with required permissions.
fix bug with sts get caller identity
Use sagemaker stack name by default, remove ability for users to define a custom stack name
|
Can you please confirm whether this PR has been tested? |
|
please resolve conflicts before merging: https://github.com/aws-samples/awsome-distributed-training/pull/510/conflicts |
|
It's been tested pre-release. Waiting on account AL to be able to test once before merging. |
mhuguesaws
reviewed
Dec 9, 2024
|
|
||
| ## 🚀 Installation and Usage | ||
| Using this script is very simple. Run ```bash automate-cluster-creation.sh``` | ||
| The automation script streamlines the process of setting up a distributed training environment using AWS SageMaker Hyperpod. |
There was a problem hiding this comment.
redunddant with previous sentence.
mhuguesaws
reviewed
Dec 9, 2024
1.architectures/5.sagemaker-hyperpod/automate-smhp-slurm/README.md
Outdated
Show resolved
Hide resolved
mhuguesaws
reviewed
Dec 9, 2024
1.architectures/5.sagemaker-hyperpod/automate-smhp-slurm/README.md
Outdated
Show resolved
Hide resolved
mhuguesaws
reviewed
Dec 9, 2024
1.architectures/5.sagemaker-hyperpod/automate-smhp-slurm/README.md
Outdated
Show resolved
Hide resolved
mhuguesaws
reviewed
Dec 9, 2024
1.architectures/5.sagemaker-hyperpod/automate-smhp-slurm/README.md
Outdated
Show resolved
Hide resolved
…E.md Co-authored-by: mhuguesaws <[email protected]>
…E.md Co-authored-by: mhuguesaws <[email protected]>
…E.md Co-authored-by: mhuguesaws <[email protected]>
…E.md Co-authored-by: mhuguesaws <[email protected]>
|
Thank you Maxime! i will merge changes after a final test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New feature (training plans) integrated into the auto create cluster script. Also updated README with better descriptions + added in gif of demo :)
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.