Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Hive Metastore Migration Reliability and Code Quality #165

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

andormarkus
Copy link

@andormarkus andormarkus commented Dec 2, 2024

Changes

This PR improves the Hive metastore migration tool in several ways:

1. Hive 3.0.0+ Compatibility

  • Added handling for CTLG_NAME column in DBS table introduced in Hive 3.0.0
  • Implemented compatibility layer in _write_dbs_table method
  • This fixes issues when migrating to newer Hive versions where CTLG_NAME is required

2. Improved Logging

  • Configured proper logging with StreamHandler
  • Added consistent log formatting
  • All log messages now include timestamp, level, and context

3. Code Quality Improvements

  • Moved class constructors to top following Python best practices
  • Improved method organization and readability
  • Fixed code formatting and alignment issues
  • Added proper docstrings for key methods

4. AWS Region Updates

  • Updated AWS regions list to include all currently supported regions
  • Separated Glue-supported regions from general AWS regions
  • Improved region validation messaging

@moomindani

…ility

- Add proper logging configuration with StreamHandler and formatter
- Fix method order in classes by moving __init__ to top
- Add compatibility fix for Hive 3.0.0+ by handling CTLG_NAME column
- Update AWS regions list with current supported regions
- Clean up code style and formatting
- Add docstring for _write_dbs_table method explaining Hive compatibility
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants