Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indy private #69

Open
wants to merge 39 commits into
base: main
Choose a base branch
from
Open

Indy private #69

wants to merge 39 commits into from

Conversation

frbrkoala
Copy link
Contributor

What does this PR do?

🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.

Motivation

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Mandatory for new node blueprints. Yes, I have added usage example to the README.md file in my blueprint folder
  • Mandatory for new node blueprints. Yes, I have implemented automated tests for all stacks in my blueprint and they pass
  • Mandatory for new node blueprints. Yes, I have added a reference to my README.md file to website/docs section for this feature
  • Yes, I have set up and ran all pre-merge quality control tools on my local machine and they don't show warnings.

For Moderators

  • The tests for all current blueprints successfully complete before merge?
  • Mandatory for new node blueprints. All pre-merge quality control tools and cdk-nag tools don't show warnings?
  • Mandatory for new node blueprints. The deployment test works on blank AWS account according to instructions in the README.md before merge?
  • Mandatory for new node blueprints. The website builds without errors?

Additional Notes

- Create a Python virtual environment and install ansible
```
$cd ansible
$ Python3 -m venv.venv
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When running python3 -m venv.venv command on Cliud9 instance getting /usr/bin/python3: No module named venv.venv


- Installs a ansible plug-in for SSH access to EC2 using the AWS Systems Manager Session Manager.
```
$ ansible-galaxy collection install community.aws
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks redundant. Message says: Starting galaxy collection install process Nothing to do. All requested collections are already installed. If you want to reinstall them, consider using --force.


## Architecture Overview

![Architecture](./doc/assets/Architecture.png)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add client to the architeture to illustrate how customers can connect and use the nodes deployed by the blueprint

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are also 3 trustee nodes, but only one is shown on the diagram. Is it correct?

This is a sample of building a Hyperledger Indy network on AWS.
The overall architecture is shown below, processing itself is performed by 4 Stewards (Validator Nodes), and network management is performed with Trustee. It consists of 4 EC2 instances for Steward and 3 EC2 instances for Trustee.

## Solution Walkthrough
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a section and responses to the Well Architected checklist. See for example:

### Well-Architected Checklist

```
$ ansible-playbook playbook/site.yml
```

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add instructions how customers can use those nodes. The simplest might be to show how to access nodes API from the Cloud9 instance the blueprint was deployed from.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add instruction on #123

Copy link
Contributor

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Jun 14, 2024
Copy link
Contributor

Pull request closed due to inactivity.

@github-actions github-actions bot closed this Jun 24, 2024
@frbrkoala frbrkoala reopened this Aug 23, 2024
add CDK tests to Hyperledger indy branch
@frbrkoala frbrkoala added the enhancement New feature or request label Aug 23, 2024
@KatsuyaMatsuoka KatsuyaMatsuoka mentioned this pull request Sep 5, 2024
9 tasks
@frbrkoala frbrkoala self-assigned this Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants