-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Indy private #69
base: main
Are you sure you want to change the base?
Indy private #69
Conversation
update documents (English and Japanese README)
Add Hyperledger Indy Node blueprint
lib/indy/README.md
Outdated
- Create a Python virtual environment and install ansible | ||
``` | ||
$cd ansible | ||
$ Python3 -m venv.venv |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When running python3 -m venv.venv
command on Cliud9 instance getting /usr/bin/python3: No module named venv.venv
lib/indy/README.md
Outdated
|
||
- Installs a ansible plug-in for SSH access to EC2 using the AWS Systems Manager Session Manager. | ||
``` | ||
$ ansible-galaxy collection install community.aws |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks redundant. Message says: Starting galaxy collection install process Nothing to do. All requested collections are already installed. If you want to reinstall them, consider using
--force.
|
||
## Architecture Overview | ||
|
||
![Architecture](./doc/assets/Architecture.png) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to add client to the architeture to illustrate how customers can connect and use the nodes deployed by the blueprint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are also 3 trustee nodes, but only one is shown on the diagram. Is it correct?
This is a sample of building a Hyperledger Indy network on AWS. | ||
The overall architecture is shown below, processing itself is performed by 4 Stewards (Validator Nodes), and network management is performed with Trustee. It consists of 4 EC2 instances for Steward and 3 EC2 instances for Trustee. | ||
|
||
## Solution Walkthrough |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a section and responses to the Well Architected checklist. See for example:
### Well-Architected Checklist |
``` | ||
$ ansible-playbook playbook/site.yml | ||
``` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to add instructions how customers can use those nodes. The simplest might be to show how to access nodes API from the Cloud9 instance the blueprint was deployed from.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add instruction on #123
cdk-nag to hyperledger indy branch
fixed ansible deploy failed for indy-private
This PR has been automatically marked as stale because it has been open 30 days |
Pull request closed due to inactivity. |
add CDK tests to Hyperledger indy branch
update Indy doc
What does this PR do?
🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.
Motivation
More
README.md
file in my blueprint folderREADME.md
file towebsite/docs
section for this featureFor Moderators
cdk-nag
tools don't show warnings?README.md
before merge?Additional Notes