Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Hyperledger Besu private network implementation to AWS Node Runners #143

Closed
wants to merge 7 commits into from

Conversation

racket2000
Copy link

@racket2000 racket2000 commented Nov 8, 2024

What does this PR do?

🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.

Motivation

Adding support for a private Hyperledger Besu network.

License

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

More

  • [yes ] Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • [ yes] Mandatory for new node blueprints. Yes, I have added usage example to the README.md file in my blueprint folder
  • [yes, run the command npx jest to execute these ] Mandatory for new node blueprints. Yes, I have implemented automated tests for all stacks in my blueprint and they pass
  • [ I am not sure what this means?] Mandatory for new node blueprints. Yes, I have added a reference to my README.md file to website/docs section for this feature
  • [I had trouble running the pre-merge quality tools. The included commands did not work for installing on my MacOS env. ] Yes, I have set up and ran all pre-merge quality control tools on my local machine and they don't show warnings.

For Moderators

  • The tests for all current blueprints successfully complete before merge?
  • Mandatory for new node blueprints. All pre-merge quality control tools and cdk-nag tools don't show warnings?
  • Mandatory for new node blueprints. The deployment test works on blank AWS account according to instructions in the README.md before merge?
  • Mandatory for new node blueprints. The website builds without errors?

Additional Notes

@frbrkoala frbrkoala changed the base branch from main to besu-private November 11, 2024 00:45
@frbrkoala frbrkoala changed the base branch from besu-private to main November 11, 2024 01:07
@frbrkoala
Copy link
Contributor

Closing this pull request without merging. The blueprint has structure very different from the Node Runners complicating the maintenance in future. The blueprint now has its own repository: https://github.com/aws-samples/besu-private-chain/tree/main . Adding Issue to create a documentation page with a link to the new blueprint's repo.

@frbrkoala frbrkoala closed this Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants