Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs for Service accounts and Grafana v10 #273

Merged
merged 3 commits into from
May 17, 2024
Merged

Update docs for Service accounts and Grafana v10 #273

merged 3 commits into from
May 17, 2024

Conversation

bonclay7
Copy link
Member

What does this PR do?

Update docs for Grafana v10 changes

Motivation

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I ran pre-commit run -a with this PR
  • Yes, I have added a new example under examples to support my PR (when applicable)
  • Yes, I have updated the Pages for this feature

Note: Not all the PRs required examples and docs.

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@bonclay7 bonclay7 requested review from elamaran11 and lewinkedrs May 16, 2024 11:25
lewinkedrs
lewinkedrs reviewed May 16, 2024
View reviewed changes
Copy link
Contributor

@lewinkedrs lewinkedrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few small grammatical fixes.

docs/eks/index.md Outdated Show resolved Hide resolved
docs/eks/index.md Outdated Show resolved Hide resolved
elamaran11
elamaran11 previously approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@elamaran11 elamaran11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the PR.

@bonclay7 bonclay7 temporarily deployed to Observability Test May 16, 2024 21:14 — with GitHub Actions Inactive
@bonclay7 bonclay7 requested a review from lewinkedrs May 16, 2024 21:15
@bonclay7 bonclay7 merged commit e9934c5 into main May 17, 2024
12 checks passed
@bonclay7
Copy link
Member Author

Merging on behalf of your approval

@bonclay7 bonclay7 deleted the mg-v10-release branch May 17, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elamaran11 elamaran11 elamaran11 left review comments

@lewinkedrs lewinkedrs Awaiting requested review from lewinkedrs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bonclay7 @elamaran11 @lewinkedrs