Nginx config options #265
Merged
Nginx config options #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix variable type mismatch for nginx pattern module * Allow partial declaration of config variables with defaults * Add telemetry log level configuration
|
Thanks for this awesome PR. Will trigger E2E tests and get this merged! |
bonclay7
approved these changes
Feb 20, 2024
This was referenced Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This fixes the nginx_config variable of the eks-monitoring module. It also adds missing configuration functionality to the otel collector and enhances module variables by removing the need to override all values of certain input maps.
Motivation
The nginx_config input variable did not function because of a variable mismatch between the eks-monitoring module and the underlying eks-monitoring/patterns/nginx module. Additionally, the otel collector was missing critical log configuration, and overriding some configurations was clunky.
More
pre-commit run -awith this PRFor Moderators
Additional Notes
This PR is related to #263