Fix: Tetrate Istio Updates #254
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bonclay7
reviewed
Jan 12, 2024
| @@ -187,28 +187,3 @@ resource "aws_prometheus_rule_group_namespace" "alerting_rules" { | |||
| for: 30m | |||
| EOF | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
why are we moving dashboards definition out of here?
There was a problem hiding this comment.
I ran into a few errors when the dashboard was kept there. I saw there were other dashboards in that file so aligned under there. Should I move it back?
There was a problem hiding this comment.
Yes if possible. We tried to separate add-ons dashbaords in their submodules, see java or nginx for example.
Dashboards included in the module don't have a separated submodule. this will help with consistency
|
This PR has been automatically marked as stale because it has been open 60 days |
|
Pull request closed due to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updating the Tetrate Istio version and aligning with the EKS Blueprints Add-ons changes
Motivation
More
pre-commit run -awith this PRNote: Not all the PRs required examples and docs.
For Moderators
Additional Notes