Node exporter dashboards (#43)

* Added dashboards for node exporter * Drop use cluster and node * Add nodename to ne metrics * Add account ID and region Co-authored-by: Venkataraman <[email protected]> Co-authored-by: Rodrigue Koffi <[email protected]>
aws-observability · Oct 24, 2022 · a42b175 · a42b175
1 parent 2e6ac04
commit a42b175
Show file tree

Hide file tree

Showing 8 changed files with 1,307 additions and 4 deletions.
diff --git a/.github/workflows/plan-examples.yml b/.github/workflows/plan-examples.yml
@@ -8,7 +8,7 @@ on:
   workflow_dispatch:
 
 concurrency:
-  group: '${{ github.workflow }} @ ${{ github.event.pull_request.head.label || github.head_ref || github.ref }}'
+  group: "${{ github.workflow }} @ ${{ github.event.pull_request.head.label || github.head_ref || github.ref }}"
   cancel-in-progress: true
 
 jobs:

diff --git a/.github/workflows/pre-commit.yaml b/.github/workflows/pre-commit.yaml
@@ -137,4 +137,4 @@ jobs:
         with:
           terraform-version: ${{ steps.minMax.outputs.maxVersion }}
           terraform-docs-version: ${{ env.TERRAFORM_DOCS_VERSION }}
-          tflint-version: ${{ env.TFLINT_VERSION }}
+          tflint-version: ${{ env.TFLINT_VERSION }}
diff --git a/.github/workflows/stale_issue_pr.yaml b/.github/workflows/stale_issue_pr.yaml
@@ -30,4 +30,4 @@ jobs:
             with no activity. Remove stale label or comment or this issue will be closed in 10 days
           stale-pr-message: |
             This PR has been automatically marked as stale because it has been open 30 days
-            with no activity. Remove stale label or comment or this PR will be closed in 10 days
+            with no activity. Remove stale label or comment or this PR will be closed in 10 days
diff --git a/modules/workloads/infra/README.md b/modules/workloads/infra/README.md
@@ -42,6 +42,7 @@ This module is inspired from the open source [kube-prometheus-stack](https://git
 | [aws_prometheus_rule_group_namespace.recording_rules](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/prometheus_rule_group_namespace) | resource |
 | [grafana_dashboard.cluster](https://registry.terraform.io/providers/grafana/grafana/latest/docs/resources/dashboard) | resource |
 | [grafana_dashboard.kubelet](https://registry.terraform.io/providers/grafana/grafana/latest/docs/resources/dashboard) | resource |
+| [grafana_dashboard.nodeexp_nodes](https://registry.terraform.io/providers/grafana/grafana/latest/docs/resources/dashboard) | resource |
 | [grafana_dashboard.nodes](https://registry.terraform.io/providers/grafana/grafana/latest/docs/resources/dashboard) | resource |
 | [grafana_dashboard.nsworkload](https://registry.terraform.io/providers/grafana/grafana/latest/docs/resources/dashboard) | resource |
 | [grafana_dashboard.workloads](https://registry.terraform.io/providers/grafana/grafana/latest/docs/resources/dashboard) | resource |

diff --git a/modules/workloads/infra/dashboards.tf b/modules/workloads/infra/dashboards.tf
@@ -28,3 +28,9 @@ resource "grafana_dashboard" "cluster" {
   folder      = var.dashboards_folder_id
   config_json = file("${path.module}/dashboards/cluster.json")
 }
+
+resource "grafana_dashboard" "nodeexp_nodes" {
+  count       = var.enable_dashboards ? 1 : 0
+  folder      = var.dashboards_folder_id
+  config_json = file("${path.module}/dashboards/nodeexporter-nodes.json")
+}